Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Batch client #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document Batch client #73

wants to merge 1 commit into from

Conversation

ddeboer
Copy link
Contributor

@ddeboer ddeboer commented Jan 5, 2016

Listed the client under the Clients & Adapters chapter. Is that okay with you, even if the client itself is actually in the client-common package? I don’t think users will mind very much which package the client comes from.

Todo:

Fix #16 and #20.

@dbu
Copy link
Contributor

dbu commented Jan 6, 2016

imho its ok to group it there. in the list on the overview page, i would put them in a 3rd section "Client Decorators" or something, to make clear these are not stand alone clients. we should add the async emulator and plugin client there as well. we should also have a section "build your own decorator" where we explain the decorator. each of those sections will need to specify the composer package in the intro.

alternatively we could add a note in the client overview page and link to an own documentation chapter on client decorators. but for me adding them within the clients seems easier.

@dbu
Copy link
Contributor

dbu commented Jul 26, 2016

opinions where this should go?

@Nyholm
Copy link
Member

Nyholm commented Jul 26, 2016

i would put them in a 3rd section "Client Decorators"

I agree.

@joelwurtz
Copy link
Member

joelwurtz commented Feb 23, 2018

Should we close this and create an issue, think @ddeboer does not have so much time, maybe it's blocking other to write this ? (As: oh! someone is already doing that no need to do that on my own)

@sagikazarmark
Copy link
Member

I wish that was the case. 😉

@joelwurtz
Copy link
Member

I always have hope :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants